Support folder other than INBOX #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add folder parameter that defaults to "INBOX"
|
Hi, Could you do step 2 of our contributing.md ? |
|
@herver Any update on this? Would like to merge it. Cheers. |
|
@electrical Step 2 (and 3) done ! Sorry for the delay ! |
|
👍 Small but usefull change! |
|
Reviewed the patch. LGTM. Thank you for helping make Logstash more awesome :) |
|
Can one of the admins verify this patch? |
jordansissel
force-pushed
the
master
branch
from
f86287d
to
a536eef
Compare
wiibaa
added a commit
to wiibaa/logstash-input-imap
that referenced
this pull request
Dec 2, 2014
Originally from elastic/logstash#921
|
CanBeClosed. Moved to logstash-plugins/logstash-input-imap#2 |
|
@herver did you recently change your github username? The git commit says the author is (view it here: https://github.com/elasticsearch/logstash/pull/921.patch) |
|
@herver the reason I ask is the git commit log has an author who's email is not listed in our "signed CLA". |
jordansissel
pushed a commit
to logstash-plugins/logstash-input-imap
that referenced
this pull request
Dec 2, 2014
Originally from elastic/logstash#921
|
Migrated as above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch add a folder parameter that defaults to "INBOX" to the IMAP input